Skip to content

fix(promote): reject non-decimal numeric limits#805

Merged
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/promote-decimal-limits
Jul 22, 2026
Merged

fix(promote): reject non-decimal numeric limits#805
ralyodio merged 1 commit into
profullstack:masterfrom
aiirvizionz:clientkit/promote-decimal-limits

Conversation

@aiirvizionz

@aiirvizionz aiirvizionz commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • require plain decimal input for promote integer limit parsers
  • reject scientific and hexadecimal numeric strings for max/delay style options
  • add direct regression coverage for promote numeric parsers

Tests

  • node_modules/.bin/vitest.CMD run packages/cli/src/commands/promote.test.ts
  • node_modules/.bin/tsc.CMD -p packages/cli/tsconfig.json --noEmit
  • git diff --check

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

5 similar comments
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

🤖 Auto-rebase: The branch was rebased successfully locally but could not be pushed to the fork. Please enable 'Allow edits from maintainers' in the PR settings, or rebase manually: git fetch upstream master && git rebase upstream/master.

@ralyodio
ralyodio merged commit 6931f6f into profullstack:master Jul 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aiirvizionz @ralyodio